Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass displayText through to LivenessCameraModule #4792

Merged
merged 3 commits into from
Dec 5, 2023

Conversation

ahnucl
Copy link
Contributor

@ahnucl ahnucl commented Nov 29, 2023

fix issue where displayText for tryAgainText do not update

Description of changes

Issue #, if available

Description of how you validated changes

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • Relevant documentation is changed or added (and PR referenced)
  • yarn test passes and tests are updated/added
  • No side effects or sideEffects field updated

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

fix issue where displayText for tryAgainText do not update
@ahnucl ahnucl requested a review from a team as a code owner November 29, 2023 19:38
Copy link

changeset-bot bot commented Nov 29, 2023

🦋 Changeset detected

Latest commit: 40d5097

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@aws-amplify/ui-react-liveness Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ahnucl ahnucl closed this Nov 29, 2023
@ahnucl ahnucl reopened this Nov 29, 2023
Copy link
Contributor

@thaddmt thaddmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution!

@reesscot reesscot changed the title Update LivenessCameraModule.tsx fix: pass displayText through to LivenessCameraModule Dec 5, 2023
@thaddmt thaddmt added the run-tests Adding this label will trigger tests to run label Dec 5, 2023
@thaddmt thaddmt merged commit fe68b66 into aws-amplify:main Dec 5, 2023
34 checks passed
@github-actions github-actions bot mentioned this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-tests Adding this label will trigger tests to run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants