feat(ui): component theming #4883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dbanksdesign
commented
Apr 18, 2024
| /** | ||
| * [📖 Docs](https://ui.docs.amplify.aws/react/components/theme) | ||
| */ | ||
| export const Theme: ThemeType = Object.assign( |
dbanksdesign
commented
Apr 18, 2024
| @@ -13,6 +13,11 @@ | |||
| "import": "./dist/esm/internal.mjs", | |||
| "require": "./dist/internal.js" | |||
| }, | |||
| "./theme": { | |||
There was a problem hiding this comment.
rename to server
dbanksdesign
commented
Apr 18, 2024
| Element | ||
| >; | ||
|
|
||
| const ThemePrimitive: Primitive<ThemeProps, 'div'> = ( |
There was a problem hiding this comment.
Add @experimental
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Splitting up this PR. First one just adds functionality. Next ones will add examples and docs.
Adding the ability to completely theme components (with any css property). This opens up a few critical use-cases:
Issue #, if available
Description of how you validated changes
Checklist
yarn testpasses and tests are updated/addedsideEffectsfield updatedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.