Separate Gen1 and Gen2 environments pull(v1) #5267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
zchenwei
changed the title
zchenwei
force-pushed
the
gen2-auth-environment-v2
branch
from
698664f
to
d0d2fab
Compare
zchenwei
commented
May 24, 2024
| @@ -290,7 +327,7 @@ jobs: | |||
| run: yarn ${{ matrix.example }}-example build | |||
|
|
|||
| - name: Start ${{ matrix.example }} example | |||
| run: yarn ${{ matrix.example }}-example start & npx wait-on -c waitOnConfig.json -t 20000 http-get://localhost:3000/ui/components/authenticator/sign-in-with-username | |||
| run: yarn ${{ matrix.example }}-example start & npx wait-on -c waitOnConfig.json -t 20000 http-get://localhost:3000/ui/components/authenticator/sign-in-with-email | |||
There was a problem hiding this comment.
Change to a route that is supported by both gen1 and gen2
zchenwei
changed the title
zchenwei
changed the title
zchenwei
changed the title
zchenwei
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
angular-gen2,next-gen2,vue-gen2). Cannot use the same apps to set up Gen1 and Gen2 since the environments pull are separated. Either gen1 or gen2 configs will be missing and the apps will not compile@gen1and@gen2. 90% of them can be shared but a few scenarios will be differentiated(e.g., no username login in Gen2, error messages are different, etc)AuthenticatorandStoragecomponents only. If we agree to take this direction, I will make the updates for other componentsChecklist
yarn testpasses and tests are updated/addedsideEffectsfield updatedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.