Fix #1733. Force to obtain new tokens if accessToken is nil #1734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…if accessToken is nil.
|
This will need a test before merging |
|
We'll need to understand the intent behind the original behavior. I don't immediately see why we'd call |
|
@palpatim Is there an estimated time? Note that is a serious bug: Our app won't work properly after this will solved. Don't hesitate to ask me if you have any doubts. Thank you! |
|
Any updates about this PR? |
|
@palpatim When do you plan to release the fix of this issue? |
palpatim
approved these changes
Sep 24, 2019
royjit
added a commit
that referenced
this pull request
Sep 24, 2019
After the user attribute update, Cognito clears the session. But this is not later refreshed. This change add test to catch this behavior. This test will fail until the PR #1734 is pushed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications in
GetSessionInternalmethod to force to obtain new tokens if accessToken is nilIssue #, if available: #1733
Description of changes:
Retrieve access token value in order to check if it is null. In that case, we have to retrieve new tokens. This situation can happen after calling
clearSessionmethod.See #1733 for more information.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.