Changing intValue to longLongValue #1836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
royjit
approved these changes
Sep 6, 2019
|
Thank you @benmckillop for the PR, this is merged to develop branch. Should be available in the next release of the SDK. |
|
Interesting! Looks like this is only for progress reporting in the multipart upload flow. What about upload and download? I think if you now try to download the large file, it should fail with the same error right? |
|
We released this in https://github.com/aws-amplify/aws-sdk-ios/releases/2.11.0 |
palpatim
added a commit
that referenced
this pull request
Sep 18, 2019
* develop: [email] Update models to latest (#1857) [ec2] Update models to latest (#1856) [bump version 2.11.0] (#1849) Updated the CHANGELOG file (#1848) Add CHANGELOG entry for S3 progress reporting fix (#1826) Project file cleanup (#1839) [transcribe] Update models to latest (#1846) Updated AWSMobileClient to access the new header as public (#1843) Fixed boolean casting in AWSCognito (#1844) Changing intValue to longLongValue in AWSTransferUtility (#1836) Downgraded swift version for unittest (#1841) Added Cancellation token to cancel on going credential fetch (#1840) Initialize in-memory 'internalCredentials' from keychain (#1678) add support for in-memory configuration to address #1649 (#1812) [sqs] Update models to latest (#1832) [lambda] Update models to latest (#1831) Removed deprecated methods (#1738) AWSMobile Client fixes - Balance semaphore's wait and signal calls. (#1824) Moved user state listener before completion handler call (#1822)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having an issue that if the file being uploaded is bigger than 2323693218 bytes, then the intValue call results in an overflow and the comparison fails. The change to longLongValue prevents the overflow.
Description of changes:
Changed the length of bytes sent so far in a multipart task to be of type longLongValue rather than intValue that it was previously
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.