Clear CustomAuthChallenge Task on SignOut #2265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
royjit
approved these changes
Jan 31, 2020
|
LGTM |
thomers
pushed a commit
to thomers/aws-sdk-ios
that referenced
this pull request
Feb 13, 2020
…2.12.7-Upgrade * commit '0ce485952faf24fbe6e9fb8cd064a9e844d95bad': (187 commits) [bump version 2.12.7] (aws-amplify#2286) Copy x86_64-apple-ios-simulator swiftmodule files for AWSMobileClient… (aws-amplify#2281) CHANGELOG for 2020-02-10-08-01 model updates (aws-amplify#2285) [iot] Update models to latest (aws-amplify#2284) [ec2] Update models to latest (aws-amplify#2283) Update CHANGELOG (aws-amplify#2279) fix CocoaPods publish deploy logic (aws-amplify#2277) Allow for static lib generation using workaround for swift/obj-c mixed projects (aws-amplify#2267) EC2 integration test bug fix (aws-amplify#2270) Remove all user attributes for new password required flow (aws-amplify#2203) (aws-amplify#2240) (aws-amplify#2255) Fix NSInternalInconsistencyException on new password required flow (aws-amplify#2254) Clear CustomAuthChallenge Task on SignOut (aws-amplify#2265) CHANGELOG for 2020-01-26-08-15 model updates (aws-amplify#2259) [lambda] Update models to latest (aws-amplify#2258) [kms] Update models to latest (aws-amplify#2257) [ec2] Update models to latest (aws-amplify#2256) Updating CHANGELOG per request in aws-amplify#2240 (aws-amplify#2252) Filter out non-mutable attribute "email_verified" for new password required flow (aws-amplify#2203) (aws-amplify#2240) CHANGELOG for 2020-01-19-08-15 model updates (aws-amplify#2244) [ec2] Update models to latest (aws-amplify#2243) ... # Conflicts: # AWSAuthSDK/Sources/AWSAuthUI/AWSAuthUIViewController.m # AWSAuthSDK/Sources/AWSAuthUI/AWSSignInViewController.m # AWSAuthSDK/Sources/AWSAuthUI/SignIn.storyboard # AWSAuthSDK/Sources/AWSMobileClient/AWSMobileOptions.swift # AWSAuthSDK/Sources/AWSMobileClient/Internal/_AWSMobileClient.m # AWSAuthSDK/Sources/AWSUserPoolsSignIn/UserPoolsUI/AWSUserPools.storyboard # AWSAuthSDK/Sources/AWSUserPoolsSignIn/UserPoolsUI/AWSUserPoolsUIHelper.m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Providing a fix for #2261
Description of changes:
CustomAuthChallengeTask does not clear on sign out so if sign in challenge wasn't completed and sign out was called first, you receive an error of "Missing required parameter ANSWER"
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.