Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove unused completion handler and cleanup #4067

Merged
merged 6 commits into from Mar 31, 2022
Merged

chore: Remove unused completion handler and cleanup #4067

merged 6 commits into from Mar 31, 2022

Conversation

royjit
Copy link
Member

@royjit royjit commented Mar 30, 2022 •
edited

Description of changes: Logic that uses completion source were removed with these PRs:

Check points:

  • Added new tests to cover change, if needed
  • All unit tests pass
  • All integration tests pass
  • Updated CHANGELOG.md
  • Documentation update for the change if required
  • PR title conforms to conventional commit style

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@royjit royjit requested a review from a team March 30, 2022 16:06
harsh62
harsh62 approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@harsh62 harsh62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from royjit.gettokenHostedUI to main March 30, 2022 18:08
@royjit royjit merged commit 1b761eb into main Mar 31, 2022
@royjit royjit deleted the royjit.awsmclcean branch March 31, 2022 21:23
samkudr pushed a commit to samkudr/aws-sdk-ios that referenced this pull request Sep 26, 2022
@royjit @samkudr
chore: Remove unused completion handler and cleanup (aws-amplify#4067)
85b8031
gabek pushed a commit to KeepSafe/aws-sdk-ios that referenced this pull request Aug 31, 2023
@royjit @gabek
chore: Remove unused completion handler and cleanup (aws-amplify#4067)
f372c17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harsh62 harsh62 harsh62 approved these changes

@awsmobilesdk awsmobilesdk Awaiting requested review from awsmobilesdk awsmobilesdk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@royjit @harsh62