Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update cache control for apigateway #4478

Merged
merged 6 commits into from Dec 29, 2022
Merged

chore: Update cache control for apigateway #4478

merged 6 commits into from Dec 29, 2022

Conversation

royjit
Copy link
Member

@royjit royjit commented Dec 27, 2022 •
edited

Issue #, if available:

Description of changes:

Check points:

  • Added new tests to cover change, if needed
  • All unit tests pass
  • All integration tests pass
  • Updated CHANGELOG.md
  • Documentation update for the change if required
  • PR title conforms to conventional commit style

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@royjit royjit requested review from a team and awsmobilesdk as code owners December 27, 2022 19:03
ameter
ameter approved these changes Dec 29, 2022
View reviewed changes
Copy link
Contributor

@ameter ameter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ameter ameter merged commit dea349c into main Dec 29, 2022
@ameter ameter deleted the royjit.apigatewaycache branch December 29, 2022 15:34
gabek pushed a commit to KeepSafe/aws-sdk-ios that referenced this pull request Aug 31, 2023
@royjit @gabek
chore: Update cache control for apigateway (aws-amplify#4478)
6b8f93e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ameter ameter ameter approved these changes

@awsmobilesdk awsmobilesdk Awaiting requested review from awsmobilesdk awsmobilesdk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@royjit @ameter