chore(AWSMobileClient): Add validation for the initial state of AWSMobileClient #4547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
royjit
force-pushed
the
royjit.formatawsmc
branch
from
75ba729
to
1c5e568
Compare
royjit
force-pushed
the
royjit.formatawsmc
branch
from
1c5e568
to
b0fbdc5
Compare
royjit
changed the title
thisisabhash
requested changes
Feb 21, 2023
AWSAuthSDK/AWSAuthSDK.xcodeproj/xcshareddata/xcschemes/AWSMobileClient.xcscheme
Outdated
Show resolved
Hide resolved
| // UserPoolOperationHandler should be initialized after AWSMobileClient init and AWSInfo init is | ||
| // completed, because it require the AWSInfo to be in a valid state to initialize. To acheive this | ||
| // currently userpoolOpsHelper is initialized inside `_internalInitialize`. | ||
| internal var userpoolOpsHelper: UserPoolOperationsHandler! |
There was a problem hiding this comment.
can we add a note here that this should be accessed synchronously
There was a problem hiding this comment.
not sure what you meant here?
There was a problem hiding this comment.
i think UserpoolOpsHelper needs to be accessed in a synchronized way, like in a initializationqueue.sync block - i thought it'd be good idea to note it here
There was a problem hiding this comment.
no, that sync block is for intializing AWSMC, but UserPoolOpsHelper by itself can be accessed from an async context as well.
AWSAuthSDK/Tests/AWSMobileClientUnitTestWithApp/Helpers/AWSMobileClientHelper.swift
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: Add validation while initializing AWSMobileClient, this PR will make sure that the user is has valid data from keychain before moving them to a signedIn state during initialization.
Check points:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.