Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Transfer-Encoding from streaming signature #638

Merged
merged 1 commit into from Sep 27, 2017
Merged

Remove Transfer-Encoding from streaming signature #638

merged 1 commit into from Sep 27, 2017

Commits on Apr 13, 2017

  1. Remove Transfer-Encoding from streaming signature

    http://docs.aws.amazon.com/AmazonS3/latest/API/sigv4-streaming.html 
    doesn't provide any detail related to `Transfer-Encoding` to be a valid 
    header as a requirement. 
    
    Additionally also Transfer-Encoding is used as part of signature 
    request incorrectly because the transfer coding names are case 
    insensitive[1] i.e when the canonical request is generated should
    be generated as lower cased value instead.
    
    ```
    content-encoding:aws-chunked
    content-type:image/jpeg
    host:***REDACTED***
    transfer-encoding:Chunked
    user-agent:aws-sdk-iOS/2.5.2 iOS/10.2 en_US transfer-manager
    x-amz-acl:public-read
    x-amz-content-sha256:STREAMING-AWS4-HMAC-SHA256-PAYLOAD
    x-amz-date:20170413T050829Z
    x-amz-decoded-content-length:1024000
    ```
    
    [1] - http://greenbytes.de/tech/webdav/rfc7230.html#transfer.codings
    harshavardhana committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    a3780f6 View commit details
    Browse the repository at this point in the history