Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feedback]the angular code doesn't compile #2918

Closed
jmagaram opened this issue Feb 7, 2021 · 1 comment
Closed

[Feedback]the angular code doesn't compile #2918

jmagaram opened this issue Feb 7, 2021 · 1 comment
Labels
amplify/js Issues tied to JS

Comments

@jmagaram
Copy link

jmagaram commented Feb 7, 2021

Page: /lib/datastore/examples/q/platform/js

Feedback: the onQuery method is missing, "subscription" declaration generates error when no data type is provided (using TypeScript/Angular strict mode)

Come on guys, give a little love to Angular!

@wlee221
Copy link
Contributor

wlee221 commented Sep 27, 2021

Hello @jmagaram, apologies on the late response. The subscription typing should be fixed from #3606. Specifically, we now are importing Restaurant type directly from "./API.service", which you can use to strictly type API functions. Please let us know if you see the same issue with the latest snippets.

And +1 on giving some love to Angular! There are a lot of Angular gaps we have seen with current UI components, and we'll work our best to bridge that gap in our new Angular UI components that we're developing now 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
amplify/js Issues tied to JS
Projects
None yet
Development

No branches or pull requests

3 participants