Reflect angular 12 changes to docs #3606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
offlineprogrammer
approved these changes
Sep 22, 2021
Milan-Shah
approved these changes
Sep 22, 2021
sammartinez
reviewed
Sep 22, 2021
| is enabled by default, which has a known issue with importing `aws-exports.js`. | ||
| You can resolve this by adding an <code>aws-exports.d.ts</code> to <code>src/</code> ( | ||
| <a | ||
| href="https://gist.github.com/wlee221/1b02f519e6e0ce25d3643cf2948f4467" |
There was a problem hiding this comment.
NON-BLOCKING: In the future, I believe we need to make a gist on a org account in case we need to update via the team.
There was a problem hiding this comment.
Agreed, there are other gists on docs that should be shared in org too.
This was referenced Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Closes #3376
Description of changes: This reflects Angular 12 changes to the getting started documentation. Angular 12+ turns on
"strict": trueby default, which was triggering all the typescript errors in #3376. Either developers can disable strict mode, or they can use the workaround mentioned in this PR.We should track these strict mode issues and deliver a holistic solution, which would require cross-team work. But these workaround should unblock developers for the time being.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.