chore: add serverComponentsExternalPackages callout for Next.js #7757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cshfang
reviewed
Jun 18, 2024
src/pages/[platform]/build-a-backend/server-side-rendering/index.mdx
Outdated
Show resolved
Hide resolved
src/pages/[platform]/build-a-backend/server-side-rendering/index.mdx
Outdated
Show resolved
Hide resolved
jimblanc
reviewed
Jun 18, 2024
src/pages/[platform]/build-a-backend/server-side-rendering/index.mdx
Outdated
Show resolved
Hide resolved
| ```ts title="next.config.js" | ||
| /** @type {import('next').NextConfig} */ | ||
| const nextConfig = { | ||
| // highlight-start |
There was a problem hiding this comment.
Are these comments needed?
There was a problem hiding this comment.
This is for highlighting the section that is actually needed.
HuiSF
commented
Jun 18, 2024
src/pages/[platform]/build-a-backend/server-side-rendering/index.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Jim Blanchard <jim.l.blanchard@gmail.com>
HuiSF
commented
Jun 18, 2024
src/pages/gen1/[platform]/build-a-backend/server-side-rendering/nextjs/index.mdx
Outdated
Show resolved
Hide resolved
cshfang
previously approved these changes
Jun 19, 2024
jimblanc
reviewed
Jun 19, 2024
src/pages/gen1/[platform]/build-a-backend/server-side-rendering/nextjs/index.mdx
Outdated
Show resolved
Hide resolved
…g/nextjs/index.mdx Co-authored-by: Jim Blanchard <jim.l.blanchard@gmail.com>
jimblanc
previously approved these changes
Jun 19, 2024
josefaidt
reviewed
Jun 19, 2024
src/pages/[platform]/build-a-backend/server-side-rendering/index.mdx
Outdated
Show resolved
Hide resolved
josefaidt
reviewed
Jun 19, 2024
src/pages/gen1/[platform]/build-a-backend/server-side-rendering/nextjs/index.mdx
Outdated
Show resolved
Hide resolved
…g/nextjs/index.mdx Co-authored-by: josef <josef.aidt@gmail.com>
…ex.mdx Co-authored-by: josef <josef.aidt@gmail.com>
josefaidt
approved these changes
Jun 19, 2024
cshfang
approved these changes
Jun 20, 2024
jimblanc
approved these changes
Jun 20, 2024
cwomack
approved these changes
Jun 20, 2024
jacoblogan
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Add a callout regarding the next build error:
and the recommended solution to resolve this error.
Related GitHub issue #, if available:
aws-amplify/amplify-js#12856
Instructions
If this PR should not be merged upon approval for any reason, please submit as a DRAFT
Which product(s) are affected by this PR (if applicable)?
Which platform(s) are affected by this PR (if applicable)?
Please add the product(s)/platform(s) affected to the PR title
Checks
Does this PR conform to the styleguide?
Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.
Are any files being deleted with this PR? If so, have the needed redirects been created?
Are all links in MDX files using the MDX link syntax rather than HTML link syntax?
ref: MDX:
[link](https://docs.amplify.aws/)HTML:
<a href="https://docs.amplify.aws/">link</a>When this PR is ready to merge, please check the box below
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.