Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Swift): Updating supported Xcode versions #7770

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

harsh62
Copy link
Member

@harsh62 harsh62 commented Jun 21, 2024

Description of changes:

The aim of the PR is to fix the minimum supported version of Xcode in Amplify Swift.

Instructions

If this PR should not be merged upon approval for any reason, please submit as a DRAFT

Which product(s) are affected by this PR (if applicable)?

  • amplify-cli
  • amplify-ui
  • amplify-studio
  • amplify-hosting
  • amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • Swift
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title

Checks

  • Does this PR conform to the styleguide?

  • Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.

  • Are any files being deleted with this PR? If so, have the needed redirects been created?

  • Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

    ref: MDX: [link](https://docs.amplify.aws/)
    HTML: <a href="https://docs.amplify.aws/">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@harsh62 harsh62 requested a review from a team as a code owner June 21, 2024 14:21
ruisebas
ruisebas previously approved these changes Jun 21, 2024
Copy link
Member

@ruisebas ruisebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since now all platforms have the same Xcode requirement, would it be simpler to call it out once?

Something like:

## Prerequisites
- Xcode 15.0 or later.
- An application with Amplify libraries integrated an a minimum target of any of the following:
  - iOS 13.0
  - macOS 10.15
  - // etc

hbuchel
hbuchel previously approved these changes Jun 21, 2024
@harsh62 harsh62 dismissed stale reviews from hbuchel and ruisebas via 0e59ee5 June 21, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants