Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KmsKeyId to LogGroup #27

Merged
merged 9 commits into from
Jul 15, 2020
Merged

Add KmsKeyId to LogGroup #27

merged 9 commits into from
Jul 15, 2020

Commits on Apr 25, 2020

  1. Ignore docs for now 

    Does not play nice with precommit
    @benbridts
    benbridts committed Apr 25, 2020
    Configuration menu
    Copy the full SHA
    7596883 View commit details
    Browse the repository at this point in the history

  2. Improve surrounding and Existing Code 

    - Add missing PutRetentionPolicy to permissions
- Remove extra space from LogGroupName description
- Make formatting consitent with surrounding code
    @benbridts
    benbridts committed Apr 25, 2020
    Configuration menu
    Copy the full SHA
    ff7dc2d View commit details
    Browse the repository at this point in the history

  3. Add KmsKeyId to LogGroup

    @benbridts
    benbridts committed Apr 25, 2020
    Configuration menu
    Copy the full SHA
    468a73d View commit details
    Browse the repository at this point in the history

  4. Update Readme

    @benbridts
    benbridts committed Apr 25, 2020
    Configuration menu
    Copy the full SHA
    8149540 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2020

  1. Make testing instructions easier to follow

    @benbridts
    benbridts committed May 24, 2020
    Configuration menu
    Copy the full SHA
    98a1885 View commit details
    Browse the repository at this point in the history

  2. Update with suggestion from code review 

    Co-authored-by: Maria Ines Parnisari <mparnisa@amazon.com>
    @benbridts
    benbridts and Maria Ines Parnisari committed May 24, 2020
    Configuration menu
    Copy the full SHA
    8294157 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2020

  1. Check previous resource model, to not remove twice 

    (suggestion from code review)

Co-authored-by: Maria Ines Parnisari <mparnisa@amazon.com>
    @benbridts
    benbridts and Maria Ines Parnisari committed Jun 14, 2020
    Configuration menu
    Copy the full SHA
    a82f71b View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Maria Ines Parnisari <mparnisa@amazon.com>
    @benbridts
    benbridts and Maria Ines Parnisari committed Jun 14, 2020
    Configuration menu
    Copy the full SHA
    b6f154c View commit details
    Browse the repository at this point in the history

  3. Catch all exceptions when updating the KmsKeyId

    @benbridts
    benbridts committed Jun 14, 2020
    Configuration menu
    Copy the full SHA
    e4c4fc6 View commit details
    Browse the repository at this point in the history