[DBParameterGroup] Include parameters in the ReadHandler response
#406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds DBParameterGroup.parameters in the ReadHandler response. The motivation for this change is to enable drift detector on independent group parameters. At the moment this collection is defined aas WriteOnly, instructing the drift detector to ignore it completely.
osdrv
commented
Feb 16, 2023
aws-rds-cfn-common/src/main/java/software/amazon/rds/common/logging/LoggingProxyClient.java
Show resolved
Hide resolved
moataz-mhmd
requested changes
Feb 17, 2023
There was a problem hiding this comment.
computeModifiedDBParameters will miss out of band changes for parameters that stack contains.
Example: a parameter A with value Not_default and out of band change put parameter A to value default
Suggesting to always add the parameters that contained in stack whatever values it holds beside the computed modified parameters.
moataz-mhmd
reviewed
Feb 17, 2023
aws-rds-dbparametergroup/src/main/java/software/amazon/rds/dbparametergroup/BaseHandlerStd.java
Show resolved
Hide resolved
moataz-mhmd
approved these changes
Feb 17, 2023
khebul
reviewed
Feb 21, 2023
aws-rds-cfn-common/src/main/java/software/amazon/rds/common/logging/LoggingProxyClient.java
Show resolved
Hide resolved
aws-rds-dbparametergroup/src/main/java/software/amazon/rds/dbparametergroup/ReadHandler.java
Show resolved
Hide resolved
osdrv
commented
Feb 22, 2023
aws-rds-dbparametergroup/src/main/java/software/amazon/rds/dbparametergroup/ReadHandler.java
Show resolved
Hide resolved
aws-rds-dbparametergroup/src/main/java/software/amazon/rds/dbparametergroup/ReadHandler.java
Show resolved
Hide resolved
khebul
approved these changes
Feb 22, 2023
moataz-mhmd
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds
DBParameterGroup.parametersin theReadHandlerresponse. The motivation for this change is to enable drift detector on independent group parameters. At the moment this collection is defined asWriteOnly, instructing the drift detector to ignore it completely.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.