Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function "isCloudFormation()" needs to be updated? #99

Closed
miparnisari opened this issue Apr 27, 2020 · 3 comments · Fixed by #201
Closed

Function "isCloudFormation()" needs to be updated? #99

miparnisari opened this issue Apr 27, 2020 · 3 comments · Fixed by #201

Comments

@miparnisari
Copy link
Contributor

The code says

https://github.com/aws-cloudformation/aws-cfn-lint-visual-studio-code/blob/edd51fb86441a1c48d294c4b664189c6f4d11399/server/src/server.ts#L133

But the docs say:

The following organization namespaces are reserved and cannot be used in your resource type names: Alexa, AMZN, Amazon, ASK, AWS, Custom, Dev
@PatMyron
Copy link
Contributor

Yup, organization namespace can be anything now

@miparnisari
Copy link
Contributor Author

Also, should we not be checking for SAM templates as well? (i.e. Transform: AWS::Serverless-2016-10-31)?

@PatMyron
Copy link
Contributor

Also, should we not be checking for SAM templates as well? (i.e. Transform: AWS::Serverless-2016-10-31)?

It wouldn't hurt to add, but SAM templates should already be detected by the existing logic

This was referenced Jul 30, 2020
Open
Open
This was referenced Aug 24, 2020
Open
Open
This was referenced Sep 1, 2020
Closed
Open
@PatMyron PatMyron mentioned this issue Oct 19, 2020
Closed
@PatMyron PatMyron mentioned this issue Feb 23, 2021
Closed
@PatMyron PatMyron mentioned this issue Jun 10, 2021
Merged
PatMyron added a commit to PatMyron/aws-cfn-lint-visual-studio-code that referenced this issue Oct 1, 2021
@PatMyron
Recognize templates with Registry types
b966e54 
aws-cloudformation#99
https://github.com/aws-cloudformation/cloudformation-resource-schema/#resource-type-name
@PatMyron PatMyron mentioned this issue Oct 1, 2021
Merged
kddejong added a commit that referenced this issue Oct 13, 2021
@PatMyron @kddejong
Recognize templates with only Registry types (#201)
a0e72e8 
* Recognize templates with Registry types

#99
https://github.com/aws-cloudformation/cloudformation-resource-schema/#resource-type-name

* tightening regular expression pattern

Co-authored-by: Kevin DeJong <kddejong@amazon.com>
@PatMyron PatMyron mentioned this issue Feb 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Recognize templates with only Registry types PatMyron/aws-cfn-lint-visual-studio-code
2 participants
@miparnisari @PatMyron