AWS::S3::Bucket.InventoryConfiguration Id AllowedPattern

[imrehg]

cfn-lint version: 0.32.1

Description of issue.

S3 InventoryConfiguration has a required Id property, and having any kind of string there passes the validation:

Resources:
  SomeBucket:
    Type: AWS::S3::Bucket
    Properties:
      ...
      InventoryConfigurations:
        - Id: "my daily inventory"
          ...

This will validate but will fail in the template creation/update phase, with something like:

The XML you provided was not well-formed or did not validate against our published schema (Service: Amazon S3; Status Code: 400; Error Code: MalformedXML; Request ID: ...; S3 Extended Request ID: ...)

It's because there are limitations on the characters that can be used in the Id, based on the AWS console's feedback:

Would be great to be able to validate that Id for

Name can only contain letters, numbers, underscores, periods, or dashes.

Unfortunately this requirement is not explicit in the docs (at least not obvious)

[PatMyron]

As described here, AllowedPatternRegex can be added to src/cfnlint/data/ExtendedSpecs/all/03_value_types/aws_s3.json like this:

https://github.com/aws-cloudformation/cfn-python-lint/blob/a46773c752247c51effef415bd3462eaec10ab0b/src/cfnlint/data/ExtendedSpecs/all/03_value_types.json#L33-L36

and used in src/cfnlint/data/ExtendedSpecs/all/04_property_values/aws_s3.json like this:

https://github.com/aws-cloudformation/cfn-python-lint/blob/a46773c752247c51effef415bd3462eaec10ab0b/src/cfnlint/data/ExtendedSpecs/all/04_property_values.json#L323-L329