Add new allowed patterns for AWS::S3::Bucket.InventoryConfiguration #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gergely Imreh <gergely.imreh@faculty.ai>
Codecov Report
@@ Coverage Diff @@
## master #1551 +/- ##
=======================================
Coverage 87.61% 87.61%
=======================================
Files 161 161
Lines 8898 8898
Branches 2129 2129
=======================================
Hits 7796 7796
Misses 661 661
Partials 441 441 Continue to review full report at Codecov.
|
Signed-off-by: Gergely Imreh <gergely.imreh@faculty.ai>
PatMyron
changed the title
PatMyron
reviewed
May 28, 2020
|
There are also these slightly more organized service-specific files we're slowly moving towards: but no functional difference so I'll merge these in as-is, thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gergely Imreh gergely.imreh@faculty.ai
Issue #1550
Description of changes:
Add allowed patterns for InventoryConfiguration, some of it from experience with the AWS console.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.