Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple filenames accepted but not linted #323

Closed
adamchainz opened this issue Sep 4, 2018 · 4 comments
Closed

Multiple filenames accepted but not linted #323

adamchainz opened this issue Sep 4, 2018 · 4 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@adamchainz
Copy link
Contributor

cfn-lint version: (cfn-lint --version) 0.6.1

Description of issue. The argument parser happily accepts multiple template filenames but only the first is actually checked, which could lead to someone accidentally believing all their templates are good when only the first is.

$ echo null > test1.yml
$ echo null > test2.yml
$ cfn-lint test1.yml test2.yml
E0000 Null value at line 0 column 0
test1.yml:1:1

#149 would add support for multiple filenames but until that is done this is a bit of a bug :)

@cmmeyer
Copy link
Contributor

cmmeyer commented Sep 6, 2018

Yeah, i can see where that would be confusing. We can trap that for now until we have a multi-file solution. As far as that goes, I'd be willing to re-open discussion on it now that core linting functionality has settled down a bit...

@cmmeyer cmmeyer added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Sep 6, 2018
@kddejong kddejong self-assigned this Sep 7, 2018
@kddejong
Copy link
Contributor

#331 is working towards fixing this one.

@kddejong
Copy link
Contributor

kddejong commented Oct 4, 2018

Should be fixed with v0.7.4. This looking good now @adamchainz ?

@adamchainz
Copy link
Contributor Author

Yes thanks!

@kddejong kddejong closed this as completed Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants