Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checking UpdateReplacePolicy/DeletionPolicy on more resource types #1232

Merged
merged 5 commits into from
Dec 12, 2019
Merged

Conversation

PatMyron
Copy link
Contributor

@PatMyron PatMyron commented Nov 27, 2019

#1050, #19

UpdateReplacePolicy
DeletionPolicy

  • should ignore W3011 if explicit policy is delete (follow-up PR)

Generated documentation with:

pip3 install -e .
cfn-lint --update-documentation

@PatMyron PatMyron changed the title WIP: generalizing I3011 generalizing I3011 Nov 27, 2019
def match(self, cfn):
matches = []

resources = cfn.get_resources(resource_type=['AWS::DynamoDB::Table'])
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thinking about expanding the list of resource types as well

Copy link
Contributor Author

@PatMyron PatMyron Nov 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWS::CloudFormation::Stack

AWS::EC2::Volume
AWS::ElastiCache::CacheCluster
AWS::ElastiCache::ReplicationGroup
AWS::Neptune::DBCluster
AWS::RDS::DBCluster
AWS::RDS::DBInstance
AWS::Redshift::Cluster

AWS::DynamoDB::Table
AWS::DocDB::DBCluster
AWS::FSx::FileSystem
AWS::EMR::Cluster
AWS::QLDB::Ledger

AWS::Backup::BackupVault
AWS::DocDB::DBInstance
AWS::EFS::FileSystem
AWS::Neptune::DBInstance
AWS::SDB::Domain

AWS::S3::Bucket (won't delete anyways)

@codecov

This comment has been minimized.

@PatMyron PatMyron changed the title generalizing I3011 generalizing I3011 to check UpdateReplacePolicy/DeletionPolicy on more resource types Nov 28, 2019
@PatMyron PatMyron changed the title generalizing I3011 to check UpdateReplacePolicy/DeletionPolicy on more resource types checking UpdateReplacePolicy/DeletionPolicy on more resource types Nov 28, 2019
@PatMyron PatMyron marked this pull request as ready for review December 12, 2019 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants