Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Dockerfile to install pydot #1490

Conversation

Nxtra
Copy link
Contributor

@Nxtra Nxtra commented Apr 24, 2020

Description of changes

Current behaviour
Unable to generate the graph .dot file that visualizes the dependency graph when using cfn-lint in docker.

image

Future behaviour
Being able to generate the dependency graph using the docker container of cfn-lint.
Now the file can be generated:

image

Updates

  • install pydot in the docker container.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Apr 24, 2020

Codecov Report

Merging #1490 into master will not change coverage.
The diff coverage is 91.93%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1490   +/-   ##
=======================================
  Coverage   87.54%   87.54%           
=======================================
  Files         156      156           
  Lines        8782     8782           
  Branches     2101     2101           
=======================================
  Hits         7688     7688           
  Misses        657      657           
  Partials      437      437           
Impacted Files Coverage Δ
src/cfnlint/helpers.py 78.60% <87.80%> (ø)
src/cfnlint/maintenance.py 98.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b706b2...8c8e72d. Read the comment docs.

@kddejong kddejong merged commit c59d066 into aws-cloudformation:master Apr 27, 2020
adrianmace added a commit to adrianmace/docker-cfn-python-lint that referenced this pull request Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants