-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
End support for python 3.4 #1687
End support for python 3.4 #1687
Conversation
cfd1552
to
a3e854b
Compare
Some other places to update when we deprecate Python 3.4 as well: $ git grep ' 3\.4' .
CONTRIBUTING.md:1. You will need Python 2 >= 2.7 or Python 3 >= 3.4. Verify which version you have by running `python --version`.
CONTRIBUTING.md: pip install -e . # or "pip3 install -e ." if you are using Python 3.4+
README.md:Python 2.7+ and 3.4+ are supported.
scripts/install: "and greater or Python 3.4 and greater.\n" |
no response to my email seeking internal package Python minor version deprecation guidance but SAM reaching out due to 3.4 being unsupported on their end: |
I suggest asking in #cloudformation-interest on Slack. Anecdotally, it looks like many internal packages have or are migrating off of Python 3.4, so I suspect that dropping support in cfn-lint won't have much negative impact. |
a3e854b
to
3caf869
Compare
@atkinsonm and @PatMyron I've changed this PR a little. Instead of just turning off python 3.4 all together I left some of the code as is. I think what we can say this is using Python 3.4 is at your own risk and will not be actively tested against. Additionally i don't think going forward we write code to handle specific 3.4 use cases. Our new testing with github actions does not include python 3.4 either. |
Our daily downloads for python 3.4 since early December has been less than 10 (a day). I'm hoping this should be good enough to close out the python 3.4 support portion of this. |
5d25e37
to
b2bd922
Compare
2c9fa95
to
caa8b95
Compare
@kddejong sorry, deleting |
Issue #, if available: #1291
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.