Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End support for python 3.4 #1687

Closed

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Sep 10, 2020

Issue #, if available: #1291

Description of changes:

  • End support for python 3.4

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

setup.py Outdated Show resolved Hide resolved
@kddejong kddejong force-pushed the lifecycle/end3.4support branch 2 times, most recently from cfd1552 to a3e854b Compare September 10, 2020 00:13
setup.py Outdated Show resolved Hide resolved
@PatMyron
Copy link
Contributor

Some other places to update when we deprecate Python 3.4 as well:

$ git grep ' 3\.4' .
CONTRIBUTING.md:1. You will need Python 2 >= 2.7 or Python 3 >= 3.4. Verify which version you have by running `python --version`. 
CONTRIBUTING.md:    pip install -e . # or "pip3 install -e ." if you are using Python 3.4+
README.md:Python 2.7+ and 3.4+ are supported.
scripts/install:            "and greater or Python 3.4 and greater.\n"

https://github.com/aws-cloudformation/cfn-python-lint/blob/9bb2d457b9d633910ee8b8f5afb68ab301ee20f7/README.md#L31

https://github.com/aws-cloudformation/cfn-python-lint/blob/4eccd3faa7775c16521e2b5b827b7e8c1f9bffd4/scripts/install#L188

https://github.com/aws-cloudformation/cfn-python-lint/blob/87566923ecee1ce7f808e7b72bd4a68338f51bb1/CONTRIBUTING.md#L24-L34

@PatMyron
Copy link
Contributor

@atkinsonm
Copy link

no response to my email seeking internal package Python minor version deprecation guidance

but SAM reaching out due to 3.4 being unsupported on their end:
aws/serverless-application-model#1255, aws/serverless-application-model#968, aws/serverless-application-model#1256

I suggest asking in #cloudformation-interest on Slack. Anecdotally, it looks like many internal packages have or are migrating off of Python 3.4, so I suspect that dropping support in cfn-lint won't have much negative impact.

@kddejong
Copy link
Contributor Author

@atkinsonm and @PatMyron I've changed this PR a little. Instead of just turning off python 3.4 all together I left some of the code as is. I think what we can say this is using Python 3.4 is at your own risk and will not be actively tested against. Additionally i don't think going forward we write code to handle specific 3.4 use cases. Our new testing with github actions does not include python 3.4 either.

@kddejong
Copy link
Contributor Author

kddejong commented Jan 29, 2021

Our daily downloads for python 3.4 since early December has been less than 10 (a day). I'm hoping this should be good enough to close out the python 3.4 support portion of this.

@PatMyron PatMyron closed this Jun 10, 2021
@PatMyron PatMyron deleted the branch aws-cloudformation:master June 10, 2021 18:18
@PatMyron
Copy link
Contributor

@kddejong sorry, deleting master branch automatically closed this and not sure how to re-open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants