Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/decode/subclass #2003

Merged
merged 6 commits into from
Jun 7, 2021

Conversation

kddejong
Copy link
Contributor

Issue #, if available:

Description of changes:

  • Create a new class for representing Fn::Sub
  • Update the decoder to use the new Fn::Sub class
  • Update rule W1020 and W1019 to use the new sub class

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kddejong kddejong force-pushed the feature/decode/subclass branch 4 times, most recently from 4f1a476 to 964060f Compare May 11, 2021 20:46
@kddejong kddejong force-pushed the feature/decode/subclass branch 2 times, most recently from ecc8402 to 5208eba Compare May 27, 2021 19:10
@kddejong kddejong changed the base branch from master to main June 2, 2021 15:34
@kddejong kddejong merged commit 33a7ad0 into aws-cloudformation:main Jun 7, 2021
@kddejong kddejong deleted the feature/decode/subclass branch June 7, 2021 16:43
kddejong added a commit to kddejong/cfn-python-lint that referenced this pull request Feb 28, 2022
* Add sub class to decoding
* Update to support json and change rule W1019 to use new capabilities
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant