-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rule W2530 to warn when SnapStart isn't configured correctly #2905
Conversation
2e1b456
to
d7b02a8
Compare
d7b02a8
to
9ee1a7f
Compare
a3d475d
to
ec9f468
Compare
945208b
to
af39530
Compare
@greenwoodcm and @msailes some updates have been made based on your feedback |
29553f0
to
25203c6
Compare
6d6760e
to
d06d3a7
Compare
1cb313f
to
fe80070
Compare
from cfnlint.rules import CloudFormationLintRule, RuleMatch | ||
|
||
|
||
class SnapStartSupported(CloudFormationLintRule): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious people's thoughts on if we want this lint or not. the set of runtimes supporting snapstart may change in the future. do we want to have to change this lint as that happens? should we instead just let the service be the authority on which runtimes support the feature?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cfn-lint is used to identify issues before they are implemented. Since a template with the improper configuration will fail at deployment time I would like to have cfn-lint identify the issue before I try to do a create/update stack.
As the service changes this capability we will update the rule. Plus we provide options to suppress this rule if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@greenwoodcm if the service has a spot in which we can pull this information I would gladly do so over configuring this manually. We pull a lot of data from SSM, pricing APIs, etc to build the data for our rules.
4598218
to
c43f172
Compare
Issue #, if available:
fix #2903
Description of changes:
W2530
to warn whenSnapStart
isn't configured correctlyI2530
to warn whenSnapStart
isn't configured on Java11 and Java17 runtimesE2530
to error whenSnapStart
is configured on an unsupported runtimeBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.