Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default fn validator context will be not strict type checking #3386

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Jun 24, 2024

Issue #, if available:
fix #3383

Description of changes:

  • Default fn validator context will be not strict type checking

Sub has strict types because you can't always use a number or boolean value. When nesting other functions in the Sub that strict type validation should be back to False. This will make sure the default to functions items is false and will still allow Fn Sub to be strict as needed.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@3dfb0e4). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3386   +/-   ##
=======================================
  Coverage        ?   93.24%           
=======================================
  Files           ?      323           
  Lines           ?    10992           
  Branches        ?     2295           
=======================================
  Hits            ?    10249           
  Misses          ?      415           
  Partials        ?      328           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong merged commit 9bd2a20 into aws-cloudformation:main Jun 24, 2024
22 checks passed
@kddejong kddejong deleted the fix/issue/3383 branch June 24, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors after upgrading to v1.3
1 participant