Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch build_scenerios_on_region to return list for caching #3498

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Jul 12, 2024

Issue #, if available:
fix #3495

Description of changes:

  • Switch build_scenerios_on_region to return list for caching

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.39%. Comparing base (a896807) to head (acc71b8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3498      +/-   ##
==========================================
- Coverage   93.40%   93.39%   -0.02%     
==========================================
  Files         325      325              
  Lines       11091    11087       -4     
  Branches     2328     2327       -1     
==========================================
- Hits        10360    10355       -5     
  Misses        410      410              
- Partials      321      322       +1     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong merged commit fa7bba3 into aws-cloudformation:main Jul 12, 2024
22 checks passed
@kddejong kddejong deleted the fix/issue/3495 branch July 12, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

don't honor the condition when checking the type availabilitiy
1 participant