fix(submit): only adding .json files from the inputs #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Relates to issue 1046
Description of changes:
While running cloudformation validation, if you add a README.md or anything into your
inputs/folder, you will only find out during submission that you failed to upload your resource type because the non-open source cloudformation code tries to parse every file into .json in that folder.As a result, this PR proposes the simplest fix for cloudformation-cli users, which is only uploading .json files from the input folder. That way, developers can create supplemental information for their extensions and how they are expected to be tested.
PS: if this proposal is approved, I would like to also submit a follow-up PR to use a comment tolerating JSON library to process these json files into raw JSON so that maintainers can leave comments about why they have chosen certain payload configurations in the .json file itself.
Please feel free to push back on anything and let me know if there is a greater scope I'm missing!
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.