adjusted summary report #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nina-ctrlv
reviewed
Aug 27, 2020
anshikg
reviewed
Aug 27, 2020
ammokhov
force-pushed
the
contract-test-output-adjustments
branch
6 times, most recently
from
dcb906d
to
c60b57e
Compare
ammokhov
force-pushed
the
contract-test-output-adjustments
branch
from
c60b57e
to
3ab0974
Compare
nina-ctrlv
approved these changes
Aug 28, 2020
sungkkim
approved these changes
Aug 28, 2020
PatMyron
reviewed
Nov 4, 2020
Comment on lines
+87
to
+91
| assert ( | ||
| response["resourceModel"] == current_resource_model | ||
| ), "All properties specified in the request MUST be present in the model \ | ||
| returned, and they MUST match exactly, with the exception of properties\ | ||
| defined as writeOnlyProperties in the resource schema" |
There was a problem hiding this comment.
think this error message might be misleading because there should be more exceptions:
readOnlyProperties, writeOnlyProperties, conditionallyReadOnlyProperties, defaults, insertionOrder, uniqueItems, etc.
There was a problem hiding this comment.
this been taken from the handler contract agreement
PatMyron
reviewed
Nov 4, 2020
Comment on lines
98
to
+103
| assert response["resourceModel"] == { | ||
| **current_resource_model, | ||
| **update_resource_model, | ||
| } | ||
| }, "All properties specified in the update request MUST be present in the \ | ||
| model returned, and they MUST match exactly, with the exception of \ | ||
| properties defined as writeOnlyProperties in the resource schema" |
There was a problem hiding this comment.
think this error message might be misleading because there should be more exceptions:
readOnlyProperties, writeOnlyProperties, conditionallyReadOnlyProperties, defaults, insertionOrder, uniqueItems, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
added messages to all assertions so it will be clear why certain test failed;
removed the full stack trace to a
shortoption as it outputs the assertion message and method it comes from;By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.