fix(cli): cfn test broken on Windows - NamedTemporaryFile issue
#924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 20, 2022
kddejong
approved these changes
Oct 31, 2022
ericzbeard
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #876
cfn testfails with Unhandled exception on Windows. This is due to using NamedTemporaryFile which per Python docs does NOT work the same in Windows.https://docs.python.org/3.9/library/tempfile.html#tempfile.NamedTemporaryFile
Setting
delete=Falseas workaround.NOTE - Temporary file must be explicitly cleaned up after temporary_ini_file() is called!
Fix being tracked here python/cpython#58451
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.