Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS::IAM::Role (add tagging support) #19

Closed
luiseduardocolon opened this issue Jul 30, 2019 · 4 comments
Closed

AWS::IAM::Role (add tagging support) #19

luiseduardocolon opened this issue Jul 30, 2019 · 4 comments
Labels
security identity compliance IAM, Cognito, Secrets Manager, GuardDuty, etc.
Milestone

Comments

@luiseduardocolon
Copy link
Contributor

  1. Title -> Customers would like to be able to tag IAM Roles from a CloudFormation template, after the recent introduction of the feature. Support for tags in IAM principals has been added to Boto 3 as well.
  2. Scope of request -> Add at creation, and to update existing roles.
  3. Expected behavior -> See 2.
  4. Test case recommendation (optional) ->
  5. Links to existing API doc (optional) ->
  6. Category tag (optional) -> Compute
  7. Any additional context (optional)
@pbsinclair42
Copy link

Looks like this is now supported: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-iam-role.html#cfn-iam-role-tags

@whereisaaron
Copy link

eksctl-io/eksctl#778

@jimsmith
Copy link

jimsmith commented Oct 31, 2019

@luiseduardocolon
Hello,

Having deployed CF template using the IAM Roles 'tags' https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-iam-role.html#cfn-iam-role-tags

I have found that the !Ref is not being honored.

This below works when it's hardcoded

Tags:
        - 
          Key: "keyname1"
          Value: "value1"
        - 
          Key: "keyname2"
          Value: "value2"

This below is not working and the same Parameter works for EC2 and Lambda resources.

Tags:
        - 
          Key: "keyname1"
          Value: "value1"
        - 
          Key: "Application"
          Value: !Ref Application
        - 
          Key: "keyname3"
          Value: "value3"

@mcanlas
Copy link

mcanlas commented Jan 13, 2021

I'm running into the same problem as above, where calls to !Ref aren't being resolved (the key doesn't show up at all).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security identity compliance IAM, Cognito, Secrets Manager, GuardDuty, etc.
Projects
coverage-roadmap
  
Shipped
Development

No branches or pull requests

7 participants