Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagging resource type coverage #228

Open
PatMyron opened this issue Oct 18, 2019 · 19 comments
Open

Tagging resource type coverage #228

PatMyron opened this issue Oct 18, 2019 · 19 comments
Labels
Coverage enhancement New feature or request
Milestone

Comments

@PatMyron
Copy link
Contributor

PatMyron commented Oct 18, 2019

Should be able to tag-on-create and update tags at the system tag-level, stack-level and resource-level for all resource types that support tagging natively without unnecessary resource replacement

#4, #7, #19, #28, #29, #64, #69, #74, #77, #84, #95, #96, #117, #133, #155, #176, #178, #184, #193, #194, #195, #196, #200, #202, #203, #205, #219, #231, #236, #238, #248, #277, #306, #309, #328, #340, #350, #354, #358, #394, #398

Wonder if tagging should be an issue label..

@andyjgordon
Copy link

Hi @PatMyron, I don't see AWS::Glue::Crawler in the above list, which I know suffers the same issue (stack-level tags dont get applied). Also suspect AWS::Glue::Workflow and AWS::Glue::Trigger may have the same, but would need to test. Do you want me to create an issue for these?

@benkehoe
Copy link
Contributor

As support is added for CloudFormation to add its automatic tags to more resource types, there should be a way to get those tags added to existing resources in a stack without providing a changed template.

@benbridts
Copy link

As support is added for CloudFormation to add its automatic tags to more resource types, there should be a way to get those tags added to existing resources in a stack without providing a changed template.

But it should be aware of resources that require some interruption or replacement when adding them. Eg. EIP or ElasticBeanstalk Environment

@pareddy113
Copy link

@PatMyron I see the stack level tags not being applied to AWS::EC2::VPCEndpointService as well, do you want me to create an issue for this?

@PatMyron
Copy link
Contributor Author

PatMyron commented May 1, 2020

@PatMyron I see the stack level tags not being applied to AWS::EC2::VPCEndpointService as well, do you want me to create an issue for this?

#350

@tvb
Copy link

tvb commented Jul 10, 2020

@PatMyron can you update us if there is any progress being made here?

@craigataws craigataws added this to the cov milestone Jul 21, 2020
@Maycon-Santos-sm
Copy link

@PatMyron Is this really in progress or is more of a low priority issue?

@badaldavda8
Copy link

#644 #645

@benbridts
Copy link

#652

@rgoltz
Copy link

rgoltz commented Jan 9, 2021

#742

@yvele
Copy link

yvele commented Apr 8, 2021

As support is added for CloudFormation to add its automatic tags to more resource types, there should be a way to get those tags added to existing resources in a stack without providing a changed template.

@benkehoe does your comment covers the fact that explicitly adding Tag to an existing AWS::CloudFront::Distribution does not add the tags (while adding the tags via the console works fine)?

This is not working for an existing distribution:

Distribution:
  Type: AWS::CloudFront::Distribution
  Properties:
    Tags:
      - Key: my-tag-key
        Value: my-tag-value

By the way.. any workaround?

See also https://serverfault.com/questions/898453/aws-cloudformation-change-set-is-not-adding-tags-to-the-resources

@estanqueiroa
Copy link

Please add AWS EMRCluster to this list, CFN stack-level tags are not created. Thank you

CloudFormation automatically creates the following stack-level tags with the prefix aws::

aws:cloudformation:logical-id
aws:cloudformation:stack-id
aws:cloudformation:stack-name

@ayrawat17
Copy link

#1734 :Add support for stack level tags to AWS::EC2::KeyPair

@aerle
Copy link

aerle commented Aug 28, 2023

#1786

@aerle
Copy link

aerle commented Oct 1, 2023

#1807
#1808

@zenttic-aws
Copy link

#19

@aerle
Copy link

aerle commented Dec 22, 2023

#901

@zipkid
Copy link

zipkid commented Feb 26, 2024

#1934

@desikora
Copy link

1939
1940

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Coverage enhancement New feature or request
Projects
coverage-roadmap
  
We're working on it
Development

No branches or pull requests