Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS::RDS::DBCluster - Port - Incorrect Port Specification #281

Open
lukbes opened this issue Dec 1, 2019 · 4 comments · Fixed by aws-cloudformation/aws-cloudformation-resource-providers-rds#324
Open

AWS::RDS::DBCluster - Port - Incorrect Port Specification #281

lukbes opened this issue Dec 1, 2019 · 4 comments · Fixed by aws-cloudformation/aws-cloudformation-resource-providers-rds#324
Labels
database RDS, DynamoDB, ElastiCache, Neptune, Amazon Redshift, Amazon QLDB, Amazon DocumentDB enhancement New feature or request

Comments

@lukbes
Copy link

lukbes commented Dec 1, 2019

Expected Behavior:

According to the documentation, when creating a AWS::RDS::DBCluster, if the Port property is not specified it should default to port 3306 if the Engine property is set to aurora or 5432 if it's set to aurora-postgresql.

Actual Behavior:

Regardless of the value set for the 'Engine' property, the Port property defaults to 3306.
@TheDanBlanco TheDanBlanco added enhancement New feature or request database RDS, DynamoDB, ElastiCache, Neptune, Amazon Redshift, Amazon QLDB, Amazon DocumentDB labels Dec 9, 2019
@yannickvr
Copy link

Same issue here, still not solved. It's a small change to get the portnumber in there, but an error is an error.

@kddejong
Copy link
Collaborator

kddejong commented Dec 2, 2020

Now that this repository is public we should probably cross track this one.

https://github.com/aws-cloudformation/aws-cloudformation-resource-providers-rds/blob/master/aws-rds-dbcluster/aws-rds-dbcluster.json#L117-L121

@kddejong kddejong mentioned this issue Dec 2, 2020
Closed
@WaelA WaelA changed the title AWS::RDS::DBCluster-Port - Incorrect Port Specification AWS::RDS::DBCluster - Port - Incorrect Port Specification Aug 4, 2021
@osdrv osdrv mentioned this issue Sep 30, 2022
Merged
osdrv pushed a commit to aws-cloudformation/aws-cloudformation-resource-providers-rds that referenced this issue Sep 30, 2022
[DBCluster] Set default port for aurora-postgresql to 5432 (#324)
2613891 
This commits fixes the create handler behavior in case a port value was
not provided. The default value for this port is 3306 for Aurora and
5432 for Aurora Postgres.

fixes #48
fixes aws-cloudformation/cloudformation-coverage-roadmap#281

Signed-off-by: Oleg Sidorov <sidorovo@amazon.com>
@osdrv
Copy link

osdrv commented Sep 30, 2022

The issue has been fixed now. We will update this ticket once the change gets deployed globally.

@evilensky
Copy link

evilensky commented Oct 14, 2022 •
edited
Loading

This caused downtime for us in us-west-2 this week. We did not specify EngineMode and did not specify a port and had been using 3306, as documented, for years. On the next deploy the databases of our cluster were listening on 5432 and not 3306. There is a missing case in this work it smells like:

image

@osdrv osdrv mentioned this issue Oct 17, 2022
Merged
osdrv pushed a commit to aws-cloudformation/aws-cloudformation-resource-providers-rds that referenced this issue Oct 19, 2022
[DBCluster] Set default port for aurora-postgresql on serverless only (…
b4e7d9a 
…#336)

This commit is a follow-up on #324.

As per the last change, the default port was set to 5432 on all
aurora-postgresql engine versions. According to the documentation,
provisioned engine versions should still default to 3306 no matter what
engine version was set. This commit introduces a more granular default
engine port mapping.

Refs aws-cloudformation/cloudformation-coverage-roadmap#281.

Signed-off-by: Oleg Sidorov <sidorovo@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
database RDS, DynamoDB, ElastiCache, Neptune, Amazon Redshift, Amazon QLDB, Amazon DocumentDB enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DBCluster] Set default port for aurora-postgresql to 5432
6 participants
@osdrv @evilensky @yannickvr @kddejong @TheDanBlanco @lukbes