feat(github-action): Add more styling based on discussion

action/.eslintrc.yml

@@ -47,8 +47,8 @@ rules:
     'prettier/prettier': 'error',
     'no-shadow': 'off',
     '@typescript-eslint/no-shadow': 'error',
-    'semi': 'error',
-    'semi-style': 'error',
+    'semi': ['error', 'always'],
+    'semi-style': ['error', 'last'],
     'filenames/match-regex': 'off',
     '@typescript-eslint/array-type': 'error',
     '@typescript-eslint/await-thenable': 'error',
@@ -81,8 +81,21 @@ rules:
     '@typescript-eslint/promise-function-async': 'error',
     '@typescript-eslint/require-array-sort-compare': 'error',
     '@typescript-eslint/restrict-plus-operands': 'error',
-    '@typescript-eslint/semi': 'error',
+    '@typescript-eslint/semi': ['error', 'always'],
     '@typescript-eslint/space-before-function-paren': 'off',
     '@typescript-eslint/type-annotation-spacing': 'error',
-    '@typescript-eslint/unbound-method': 'error'
+    '@typescript-eslint/unbound-method': 'error',
+    'func-style': ['error', 'declaration', { 'allowArrowFunctions': false }],
+    'sort-imports':
+      [
+        'error',
+        {
+          'ignoreCase': false,
+          'ignoreDeclarationSort': false,
+          'ignoreMemberSort': false,
+          'memberSyntaxSortOrder': ['none', 'all', 'multiple', 'single'],
+          'allowSeparatedGroups': false
+        }
+      ],
+      'sort-keys': ['error', 'asc', {'caseSensitive': true, 'natural': false, 'minKeys': 2}]
   }

action/src/checkoutRepository.ts

@@ -1,5 +1,5 @@
-import { exec } from '@actions/exec';
 import { context } from '@actions/github';
+import { exec } from '@actions/exec';
 
 enum CheckoutRepositoryStrings {
   Error = 'Error checking out repository'
@@ -9,7 +9,7 @@ enum CheckoutRepositoryStrings {
  * Checkout the appropriate ref for the users changes.
  * @returns {Promise<void>}
  */
-export const checkoutRepository = async (): Promise<void> => {
+export async function checkoutRepository(): Promise<void> {
   const ref = context.payload.ref;
   const repository = context.payload.repository?.full_name;
   try {
@@ -26,6 +26,6 @@ export const checkoutRepository = async (): Promise<void> => {
   } catch (error) {
     throw new Error(`${CheckoutRepositoryStrings.Error}: ${error}`);
   }
-};
+}
 
 export default checkoutRepository;

action/src/getConfig.ts

@@ -13,13 +13,15 @@ export type Config = {
  * Returns the config values in JSON format
  * @returns {Config}
  */
-export const getConfig = (): Config => ({
-  rulesPath: core.getInput('rules'),
-  dataPath: core.getInput('data'),
-  token: core.getInput('token'),
-  checkout: core.getBooleanInput('checkout'),
-  analyze: core.getBooleanInput('analyze'),
-  createReview: core.getBooleanInput('create-review')
-});
+export function getConfig(): Config {
+  return {
+    analyze: core.getBooleanInput('analyze'),
+    checkout: core.getBooleanInput('checkout'),
+    createReview: core.getBooleanInput('create-review'),
+    dataPath: core.getInput('data'),
+    rulesPath: core.getInput('rules'),
+    token: core.getInput('token')
+  };
+}
 
 export default getConfig;