fix unhandled Result return types #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylersouthwick
force-pushed
the
fix-unhandled-result-types
branch
2 times, most recently
from
d364b0c
to
fdd2725
Compare
joshfried-aws
approved these changes
Oct 3, 2022
tylersouthwick
force-pushed
the
fix-unhandled-result-types
branch
from
fdd2725
to
ad51603
Compare
akshayrane
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Fix unhandled result types (added
?) and updated function return types that should be returningResulttype.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license