bugfix for failing test commands + new tests to cover this #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshfried-aws
requested review from
akshayrane,
razcloud,
dchakrav-github,
Brianwithay21 and
reza-aws
razcloud
approved these changes
Nov 8, 2022
akshayrane
requested changes
Nov 8, 2022
akshayrane
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixed an issue causing test templates to fail + added 4 new tests to cover the test command
Description of changes:
Changed 2 fields on the TestSpec struct in commands/validate.rs
name: Option<serde_json::Value> -> Option (this doesnt need to be a Value, this will always be a string)
input: serde_json::Value -> serde_yaml::Value. Newer versions of serde_yaml broke this compatibility, previously we could go from serde_json::Value -> serde_yaml::Value, and vice versa. Now we are only able to safely go from serde_yaml::Value -> serde_json::Value. Hence the switch
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license