[Code Quality]: Implementing custom writer, bug fixes, new integration test framework, and adding initial tests for all commands #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added build targets to release workflow * Added build targets to release workflow * Moved TARGETS env variable * Removed JSON variable * Added OS-specific runs * Removed external dependency * Added braces to target in path * Reverting to OS-specific runs * Fixed indent * temp commit with temp fix for DI on execute method * small fix + implementing poc for a test * Added initial tests for verbose output validation * Refactoring to add Writer across all commands * Minor refactoring, removed unused imports * rename from_utf8 to into_string due to clippy warning * fixed bug from renaming from_utf8 Co-authored-by: Akshay Rane <raneaks@amazon.com> Co-authored-by: Josh Fried <joshfri@amazon.com>
…#320) * testing rust-fmt action with incorectly formatted file * reverting previous commit * testing rust-fmt action with incorectly formatted file * reverting previous commit * fixed serialization issues for enums * cleanup
Co-authored-by: Akshay Rane <raneaks@amazon.com>
* testing rust-fmt action with incorectly formatted file * reverting previous commit * testing rust-fmt action with incorectly formatted file * reverting previous commit * create test runners for validate, parse-tree, and test. refactored tests in validate to use rstest + added new test cases. added parse-tree test cases * removed unneeded cargo_test2 fn * removing unused cargo_test fn * rust fmt * more parse-tree tests * fixes as per comments * rustfmt
* Adding license info for indoc * Added tests for migrate and rulegen, added constants for status codes, incorporated writer into test command * Formatting changes * Corrected typos in resource file paths * Added license info for strip-ansi-escapes library --------- Co-authored-by: Akshay Rane <raneaks@amazon.com>
* testing rust-fmt action with incorectly formatted file * reverting previous commit * testing rust-fmt action with incorectly formatted file * reverting previous commit * more parse-tree tests * fixes as per comments * added tests for laoder and fixed some bugs found while writing tests * removed unneeded use
joshfried-aws
requested review from
akshayrane,
razcloud,
Brianwithay21,
wkexiang and
reza-aws
akshayrane
approved these changes
Jan 27, 2023
wkexiang
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#208
This PR is co-authored by @akshayrane
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license