Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WildCard JSON Lists #35

Merged
merged 6 commits into from
Jul 1, 2020
Merged

Conversation

nathanataws
Copy link
Contributor

Issue #, if available:
Addressing some parts of issue #27

What

  • Add the ability of wildcards to match against lists
  • Create JSON list type
  • Add a guard for extraneous whitespace lines
  • Update the README to discuss new wildcard and JSON list behavior

Why

  • To allow for somewhat-more-graceful handling of the different parsing of intrinsics by allowing for rules like:
let tag_vals = [{"Key":"OwnerContact","Value":"OwnerContact"},{"Key":"OwnerContact","Value":{"Ref":"OwnerContact"}}]
AWS::EC2::SecurityGroup Tags.* NOT_IN %tag_vals 
  • To fix a list parsing issue with json inside a list form and flatten it out to strings like the other list items
  • To prevent strange edge cases with whitespace lines
  • To document the changes.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

let tag_vals = [{"Key":"OwnerContact","Value":"OwnerContact"},{"Key":"OwnerContact","Value":{"Ref":"OwnerContact"}}]
AWS::EC2::SecurityGroup Tags.* NOT_IN %tag_vals << custom message

And add the ability to use wildcards with lists
…son parse tests to ensure the behavior is consistent for all json types
@nathanataws nathanataws merged commit 908ca38 into release-0.5.2 Jul 1, 2020
@nathanataws nathanataws deleted the nathanmc_wildcard_json_lists branch July 1, 2020 19:40
priyap286 pushed a commit that referenced this pull request May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant