[Fix]: Custom Message is now JSON/YAML parseable #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshfried-aws
requested review from
akshayrane,
Neel-Renavikar,
razcloud,
Brianwithay21,
wkexiang,
pamkuang,
reza-aws and
rpdutt
reza-aws
approved these changes
Aug 10, 2023
pamkuang
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#389
Description of changes:
Somewhere between the release of guard 2.0.3 and 2.1.0 the custom message when validate commands failed were no longer json/yaml parseable. This PR fixes this, and they are now parseable.
NOTE: Because this custom_message field contains json, inside of a json object, it is escaped so when parsing the user needs to use something like jq's
fromjsoncommand to continue parsing.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license