updating docs, adding is_null and is_float operators #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshfried-aws
requested review from
akshayrane,
Brianwithay21,
wkexiang,
setttings,
Neel-Renavikar,
razcloud,
pamkuang,
reza-aws,
rpdutt and
minhphuong98
Brianwithay21
approved these changes
Aug 14, 2023
minhphuong98
approved these changes
Aug 14, 2023
akshayrane
approved these changes
Aug 14, 2023
pamkuang
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#377
Description of changes:
Clarified the description for the
existsunary function in guard. Previously said it could be used in place of where a dev would use!= nullin other languages. The team believes this was slightly misleading. Exists is used to check if a query is resolved, its value doesn't matter (meaning it can be any valid value for guard, including null) and still pass.On that note we added a way to check if a value is null, using the
is_nulloperator. Doing this we also noticed that even though our docs explicitly state we support anis_floatoperation, that wasn't previously true. For this reason we added support for anis_floatoperation as well.I also noticed a slight bug with the yaml loader, where we would resolve unquoted
nulland~keywords to strings of those values. Now we check the value of a string and match against those 2 before converting to a string value. I also added tests for this case.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license