[Code Quality]: Addressing new clippy lints (warns) #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshfried-aws
requested review from
akshayrane,
setttings,
Neel-Renavikar,
Brianwithay21,
wkexiang,
frankret,
pamkuang,
brianlaoaws,
reza-aws,
rpdutt and
minhphuong98
setttings
approved these changes
Aug 24, 2023
pamkuang
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
With the release of Rust 1.72 earlier today, there was some changes to clippy lints. This PR addresses some issues that were for the time being only warns, but our intention is to get ahead of any possible future errors from the linter. This will keep noise out of future PR's that have actual logical changes made to them.
With the exception of 2 of them, most of these lints were due to this new lint https://rust-lang.github.io/rust-clippy/master/index.html#/needless_raw_string_hashes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license