[BugFix]: cfn-guard no longer errors out when rule files are empty, or contain only comments #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshfried-aws
requested review from
akshayrane,
setttings,
Neel-Renavikar,
razcloud,
Brianwithay21,
wkexiang,
frankret,
pamkuang,
brianlaoaws,
reza-aws,
rpdutt and
minhphuong98
akshayrane
reviewed
Aug 28, 2023
minhphuong98
approved these changes
Aug 28, 2023
Brianwithay21
approved these changes
Aug 28, 2023
akshayrane
approved these changes
Aug 28, 2023
joshfried-aws
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#376
Description of changes:
Added a check before parsing for the grammar, that discards all leading comments, or empty space, and made the
crate::rules::parser::rules_filefunction now returnResult<Option<RulesFile>, Error>instead ofResult<RulesFile, Error>calling functions of this now also return the sameResult<Option<RulesFile>, E>struct, and functions such asevaluate_rulenow return 0 if it receivesOk(None)functions such as the evaluator in our structured_reporter now just skip the step of appending to the list of rules.Also updated expected results of some test cases, and added a new test case for when using the validate command with a file that contains only comments
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license