[BugFix]: discovered bug in loader when handling type casted nulls #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshfried-aws
requested review from
setttings,
Neel-Renavikar,
razcloud,
Brianwithay21,
frankret,
pamkuang,
brianlaoaws,
reza-aws,
rpdutt and
minhphuong98
pamkuang
approved these changes
Nov 29, 2023
rpdutt
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
After working on #418 I had noticed there was a logical error when handling type casted null values in the loader.
Previously we would return a bad value for any value other than
nullor~when casted using!!nullthis should not be the case, and we should in fact cast any value here into null regardless of what follows.I have updated the tests to reflect this change as well
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license