[BugFix]: fixing panic in evaluator when query from typeblock is unresolved #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshfried-aws
requested review from
setttings,
Neel-Renavikar,
razcloud,
Brianwithay21,
wkexiang,
brianlaoaws,
reza-aws,
rpdutt,
minhphuong98 and
frankret
razcloud
approved these changes
Dec 7, 2023
brianlaoaws
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
We discovered another panic when running our fuzzer, this was when a query from a type_block is unresolved. Previously this was considered unreachable. Now instead of it being unreachable we return a
MissingValueerror, with some contest as to why this error occurred.We have also added an integration test to catch this.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license