Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Only show errors/failures in output #448

Merged
merged 7 commits into from
Feb 5, 2024
Merged

[Enhancement] Only show errors/failures in output #448

merged 7 commits into from
Feb 5, 2024

Conversation

dannyvassallo
Copy link
Contributor

Issue #, if available: 425

Description of changes:

  • Implements is_reportable check on SingleLineSummary
  • Refactors rules output print statements into helper
  • Updates test fixtures to expect new output
  • Adds test to check summary on "[rules & data]-dir"

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@joshfried-aws joshfried-aws mentioned this pull request Feb 2, 2024
Merged
@dannyvassallo dannyvassallo merged commit b819384 into aws-cloudformation:main Feb 5, 2024
15 checks passed
@dannyvassallo dannyvassallo deleted the failures_only branch February 5, 2024 16:36
@BrewTestBot BrewTestBot mentioned this pull request Mar 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshfried-aws joshfried-aws joshfried-aws approved these changes

@minhphuong98 minhphuong98 minhphuong98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dannyvassallo @joshfried-aws @minhphuong98