[Enhancement]: JUnit reporters for test command #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…porting behaviour to this struct
joshfried-aws
requested review from
akshayrane,
dannyvassallo,
setttings,
razcloud,
Brianwithay21,
wkexiang and
pamkuang
joshfried-aws
requested review from
brianlaoaws,
reza-aws,
rpdutt and
minhphuong98
akshayrane
approved these changes
Feb 6, 2024
pamkuang
approved these changes
Feb 6, 2024
dannyvassallo
approved these changes
Feb 6, 2024
minhphuong98
approved these changes
Feb 6, 2024
dannyvassallo
pushed a commit
to dannyvassallo/cloudformation-guard
that referenced
this pull request
Feb 9, 2024
* init commit for junit reporter WIP / MVP example * misc tweeks * updating install script to check for architecture and download the correct artifactj * [misc]: temp * cleanup * cleanup * updating error codes for ffi * cleanup * uncommenting junit test * [misc]: temp * cleanup * init commit junit reporters for test command * removing rust fmt file * removing unused file * fix breaking build * updating exit code to use contant over literals * refactoring project structure * cleanup * cleanup * rebasing + merge conflicts * creating generic reporter for test command, and refactoring legacy reporting behaviour to this struct * updating exit code to use contant over literals * refactoring some duplicated code among the test reporters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#265
Description of changes:
This PR adds a new JUnit reporting mechanism for the test command. This new output format has the same requirements as mentioned in #447.
In addition to this implementation I have also gone ahead and split up the legacy reporting behaviour from the test.rs file, and created a GenericReporter struct that is now responsible for the legacy reporting behaviour.
While adding these 2 new reporting structs, I refactored the package structure for the validate reporters, we now have a reporters mod, and inside of that there is a mod for test, and validate.
Also includes misc changes to reduce code duplication between the different reporting mechanisms for the test command
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license