Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Show full path to file #410 #457

Merged
merged 3 commits into from Feb 13, 2024

Conversation

dannyvassallo
Copy link
Contributor

Issue #, if available: 410

Description of changes:

  • Exposes the full path of the data file name during validation
  • Sanitizes the path from the CLI output during tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

guard/src/commands/validate.rs Outdated Show resolved Hide resolved
guard/tests/utils.rs Show resolved Hide resolved
guard/tests/utils.rs Show resolved Hide resolved
guard/tests/utils.rs Show resolved Hide resolved
Copy link
Contributor

@joshfried-aws joshfried-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

guard/tests/utils.rs Show resolved Hide resolved
@dannyvassallo dannyvassallo merged commit 786c7b3 into aws-cloudformation:main Feb 13, 2024
16 checks passed
@dannyvassallo dannyvassallo deleted the full_paths branch February 13, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants