Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add support for windows #460

Merged
merged 10 commits into from Feb 15, 2024

Conversation

dannyvassallo
Copy link
Contributor

@dannyvassallo dannyvassallo commented Feb 15, 2024

Issue #, if available: 411

Description of changes:

  • Adds windows release workflow
  • Adds ps1 file to automatically install guard and add it to the path
  • Updates readme to guide users.

Validated the readme script and ps1 on my PC.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Copy link
Contributor

@joshfried-aws joshfried-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, please add a workflow to test the install script once this is merged, and we have a windows binary uploaded.

@dannyvassallo dannyvassallo merged commit 500e0ef into aws-cloudformation:main Feb 15, 2024
16 checks passed
dannyvassallo added a commit to dannyvassallo/cloudformation-guard that referenced this pull request Feb 15, 2024
* Update release workflow to build for windows

* new line at end of workflow

* Create powershell install script

* Fix typo

* Update ps1 file and add readme instructions

* Use system path and not user

* Remove whitespace

* wrong value for aarch64 in switch

* use bin dir not bin directly

* Add infor about execution policy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants