[Code Quality]: default implementation for reader and writer #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshfried-aws
changed the title
joshfried-aws
requested review from
setttings,
razcloud,
Brianwithay21,
wkexiang,
pamkuang,
brianlaoaws,
rpdutt and
minhphuong98
brianlaoaws
approved these changes
Feb 16, 2024
rpdutt
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Misc code quality changes to make changes to our custom reader and writer.
Implement a default method for both (default now uses stdout and stderr), this reduces the verbosity when writing tests, as well as changing the signature of the Writer::new method, to only accept a single parameter, setting the err writer to stderr. To allow for more flexibility I added another method called
new_with_err.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license