Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grammar for cfn-guard rulesets #65

Merged
merged 18 commits into from Oct 1, 2020

Conversation

johnttompkins
Copy link
Contributor

@johnttompkins johnttompkins commented Sep 24, 2020

Issue #, if available:

Description of changes: ABNF definition of the cfn-guard ruleset grammar. Looked at the cfn-guard README and the parser to determine some of this. Still a work in progress so leaving as a draft for now to hone and collect feedback.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@PatMyron
Copy link
Contributor

Should environment variables be added?

@johnttompkins
Copy link
Contributor Author

Should environment variables be added?

Good call. Will add that as a terminal case

GRAMMAR.md Outdated Show resolved Hide resolved
Copy link

@ammokhov ammokhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good if you are familiar with semantics but should we do a resource example?

@johnttompkins
Copy link
Contributor Author

this looks good if you are familiar with semantics but should we do a resource example?

Resource example? like an example of a ruleset? the readme has several examples of valid rules: https://github.com/aws-cloudformation/cloudformation-guard/blob/master/README.md Do you think we should include more here? Was just shooting to scope this document to defining the grammar.

Copy link

@ammokhov ammokhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good if you are familiar with semantics but should we do a resource example?

Resource example? like an example of a ruleset? the readme has several examples of valid rules: https://github.com/aws-cloudformation/cloudformation-guard/blob/master/README.md Do you think we should include more here? Was just shooting to scope this document to defining the grammar.

nice abnf addition, lgtm

GRAMMAR.md Outdated Show resolved Hide resolved
GRAMMAR.md Outdated Show resolved Hide resolved
John Tompkins and others added 3 commits September 30, 2020 14:51
Co-authored-by: Pat Myron <PatMyron@users.noreply.github.com>
Co-authored-by: Pat Myron <PatMyron@users.noreply.github.com>
@johnttompkins johnttompkins marked this pull request as ready for review September 30, 2020 21:55
@PatMyron PatMyron dismissed their stale review September 30, 2020 21:57

syntax highlighted

@johnttompkins johnttompkins merged commit 752112c into aws-cloudformation:master Oct 1, 2020
@johnttompkins johnttompkins deleted the grammar branch October 1, 2020 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants