New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add grammar for cfn-guard rulesets #65
Add grammar for cfn-guard rulesets #65
Conversation
Should environment variables be added? |
Good call. Will add that as a terminal case |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good if you are familiar with semantics but should we do a resource example?
Resource example? like an example of a ruleset? the readme has several examples of valid rules: https://github.com/aws-cloudformation/cloudformation-guard/blob/master/README.md Do you think we should include more here? Was just shooting to scope this document to defining the grammar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good if you are familiar with semantics but should we do a resource example?
Resource example? like an example of a ruleset? the readme has several examples of valid rules: https://github.com/aws-cloudformation/cloudformation-guard/blob/master/README.md Do you think we should include more here? Was just shooting to scope this document to defining the grammar.
nice abnf addition, lgtm
Co-authored-by: Pat Myron <PatMyron@users.noreply.github.com>
Co-authored-by: Pat Myron <PatMyron@users.noreply.github.com>
Issue #, if available:
Description of changes: ABNF definition of the cfn-guard ruleset grammar. Looked at the cfn-guard README and the parser to determine some of this. Still a work in progress so leaving as a draft for now to hone and collect feedback.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.